Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Remove "nuget.org" references in WBT #104806

Merged
merged 4 commits into from
Jul 18, 2024
Merged

[wasm] Remove "nuget.org" references in WBT #104806

merged 4 commits into from
Jul 18, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 12, 2024 •
edited
Loading

Follow-up that fixes #104737.

ToDo:

  • SkiaSharp used e.g. in NativeBuild_WithDeployOnBuild_UsedByVS or WithDllImportInMainAssembly:
No packages exist with this id in source(s): /root/helix/work/workitem/e/dotnet-latest/library-packs, dotnet8, dotnet9, nuget-local
  • Microsoft.NETCore.App.Ref in NonWasmTemplateBuildTests.NonWasmConsoleBuild_WithoutWorkload
 Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.30)
 Found 1 version(s) in nuget-local [ Nearest version: 9.0.0-ci ]

Fixed by adding dotnet-public.

@ilonatommy ilonatommy self-assigned this Jul 12, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

ViktorHofer
ViktorHofer approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm suprised that you don't need the dotnet-public package source.

@ilonatommy
Copy link
Member Author

I'm suprised that you don't need the dotnet-public package source.

Not sure yet, let's see how CI will react. I did not test this, that's why I put only a draft.

This was referenced Jul 12, 2024
Open
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 15, 2024
Open
@ilonatommy ilonatommy marked this pull request as ready for review July 17, 2024 13:13
@ilonatommy ilonatommy requested a review from maraf as a code owner July 17, 2024 13:13
@ilonatommy ilonatommy merged commit 1c4ac7d into dotnet:main Jul 18, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Build-mono Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[browser][WBT] SignalRPassMessageWasmBrowser - NU1903 - System.Text.Json 8.0.0
3 participants
@ilonatommy @ViktorHofer @maraf